[6.x] Fix @param names that do not match the signatures - #15120
Merged
Conversation
Twenty entries across sixteen files name an argument the method does not take: mostly renames the docblock did not follow, plus a few tags for parameters that were removed, and one modifier documenting one argument where three are taken. Docblocks only.
jasonvarga
enabled auto-merge (squash)
August 5, 2026 03:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #15119, which you merged earlier — this is the batch I mentioned there.
Twenty
@paramtags name an argument the method does not take. Each was opened and read against its signature before changing.Renames the docblock did not follow
src/Support/Arr.php:220removeNullValues$array$datasrc/Assets/AssetFolder.php:165rename$filename$namesrc/Assets/AssetContainer.php:529warmPresets$presets$presetsrc/Auth/File/User.php:140setRememberToken$value$tokensrc/Console/Processes/Process.php:161withoutLoggingErrors$callable$callbacksrc/Contracts/Forms/Submission.php:54get$key$fieldsrc/Contracts/Forms/Form.php:9handle$name$handlesrc/Contracts/View/Antlers/Parser.php:58getVariable$data$contextsrc/Http/Controllers/GlideController.php:82generateByAsset$ref$encodedsrc/StaticCaching/Cachers/AbstractCacher.php:254refreshUrl$path$urlsrc/Modifiers/CoreModifiers.php:1710md5$params$valuesrc/Http/Controllers/CP/Updater/UpdateProductController.php:16show$slug$marketplaceProductSlugsrc/Http/Controllers/CP/Updater/UpdateProductController.php:65changelog$slug$marketplaceProductSlugTags for parameters that are not there at all
src/Assets/Asset.php:1019blueprintstring|null $blueprintsrc/Console/Commands/MakeWidget.php:72generateWidgetView$addon$addoncomes from$this->argument('addon')src/Contracts/Forms/Submission.php:71delete$keysrc/CP/Navigation/NavBuilder.php:33__construct$withHidden$itemssrc/Imaging/GlideUrlBuilder.php:23build$filename$item,$paramssrc/Modifiers/CoreModifiers.php:2901timestamp$params$valueOne that was short rather than wrong
src/Modifiers/CoreModifiers.php:1196inArraydocumented a single$valuewhile the method takes$haystack, $params, $context. Filled it in followingcontains()in the same file, which has the identical signature and a complete block.No signature, call site, or behaviour is touched.
Left alone
src/CP/Navigation/NavItem.php:570name(...$arguments)documents$name. It is variadic, so documenting what it actually accepts looks deliberate rather than stale — that one is your call, not mine.